Add pydbus stubs #13921
Add pydbus stubs #13921
Conversation
Tatsh
force-pushed
the
pydbus
branch
4 times, most recently
from
a4baf4d to
d4870ab
Compare
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Thanks, not a full review, but two things I noticed:
You are using Any in many places, where a proper type could be substituted. In those cases, either remove the type annotation or use Incomplete from _typeshed where removing it would not work properly (for example, because Any is used in a union). In all remaining cases, Any needs to documented with the accepted or possible types and the reason for using Any.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Tatsh
force-pushed
the
pydbus
branch
2 times, most recently
from
50cc2d0 to
1b118a4
Compare
This comment has been minimized.
This comment has been minimized.
Co-authored-by: Sebastian Rittau <[email protected]>
Co-authored-by: Sebastian Rittau <[email protected]>
Co-authored-by: Sebastian Rittau <[email protected]>
Co-authored-by: Sebastian Rittau <[email protected]>
This comment has been minimized.
This comment has been minimized.
|
LGTM, but we need to find out why CI fails. I think it's because PyGObject-stubs doesn't declare a dependency on pygobject. Until someone beats me to it, I will investigate more tomorrow. You could try to add a |
This comment has been minimized.
This comment has been minimized.
|
@Tatsh Ok, I got stubtest running properly by adding some APT dependencies. But now there are a few proper stubtest complaints. Could you have a look? |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
I would prefer to not export |
This comment has been minimized.
This comment has been minimized.
stubs/pydbus/pydbus/proxy.pyi
Outdated
| class ProxyMixin(Generic[_T]): | ||
| def get(self, bus_name: str, object_path: str | None = None, *, timeout: int | None = None) -> _CompositeObject[_T]: ... | ||
| @type_check_only | ||
| class OrgBluezAdapter1Dict(TypedDict, total=False): |
There was a problem hiding this comment.
I'm sorry I didn't notice this earlier, but type check only types should be prefixed with _, e.g. _OrgBluezAdapter1Dict.
There was a problem hiding this comment.
I had to add # noqa: Y049 for these types. Ruff does not see these as used even though they are getting passed into TypedDict().
There was a problem hiding this comment.
How do I fix this issue? https://github.com/python/typeshed/actions/runs/14883678415/job/41797568758?pr=13921#step:5:317
There was a problem hiding this comment.
You can add it to the stubtest allowlist
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
https://github.com/LEW21/pydbus/tree/master/pydbus
Upstream is extremely sporadic and currently not active.
In
bus.pyithere are overloads for org.bluez and org.freedesktop.Notifications.